❮

pgstattuple: add test for coverage

  • Jump to comment-1
    sh95119@gmail.com2022-08-02T01:36:33+00:00
    Hi, hackers I added some SQL statements to improve test coverage. As data was inserted, the expected file changed. So should I change all `select *` for a stable expected result? And it's the coverage change as I add 50.6% -> 78.7% --- regards, Lee Dong Wook
    • Jump to comment-1
      tgl@sss.pgh.pa.us2022-08-02T05:47:58+00:00
      Dong Wook Lee <sh95119@gmail.com> writes: > Hi, hackers > I added some SQL statements to improve test coverage. I do not think it's a great idea to create random dependencies between modules like the pgstattuple -> bloom dependency you casually added here. regards, tom lane
      • Jump to comment-1
        sh95119@gmail.com2022-08-03T02:19:59+00:00
        Tom Lane <tgl@sss.pgh.pa.us> writes: > I do not think it's a great idea to create random dependencies > between modules like the pgstattuple -> bloom dependency you > casually added here. I agree with your option. Is there no problem with selecting all the columns during SELECT statements? I thought there might be a problem where the test results could change easily. --- regards Lee Dong Wook.